Skip to content

[WIP] Remove custom parameters #245

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

[WIP] Remove custom parameters #245

wants to merge 2 commits into from
+0 −22

Conversation

RemiLehe
Copy link
Collaborator

It does not look like the custom parameters are used by any existing test.
For the sake of simplifying the code, I would suggest to remove them.

@RemiLehe RemiLehe changed the title Remove custom parameters [WIP] Remove custom parameters Sep 24, 2024
@RemiLehe
Copy link
Collaborator Author

Custom parameters are used by the Ax generators. For instance ax_trial_id is a custom parameter.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MaxThevenet MaxThevenet Awaiting requested review from MaxThevenet

@delaossa delaossa Awaiting requested review from delaossa

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@RemiLehe